diff options
| author | Bryce Johnson <bryce@gitlab.com> | 2017-06-12 14:43:21 -0400 |
|---|---|---|
| committer | Bryce Johnson <bryce@gitlab.com> | 2017-06-29 12:50:45 -0400 |
| commit | 81e9c2842574b10d694a8e29665c77fde7fd6ae5 (patch) | |
| tree | c7fad475df58553505885b9e2de9b9543bc6d3f3 /features | |
| parent | 066a6c8ba8900f0883ee788d901d300850b1ae61 (diff) | |
| download | gitlab-ce-81e9c2842574b10d694a8e29665c77fde7fd6ae5.tar.gz | |
Render add-diff-note button with server.
This commit moves the rendering of the button back to the server, and
shows/hides it using opacity rather than display. It also removes the
transform applied to the button on hover (scale). Previously, both of these
factors automatically triggered a reflow, which creates a performance
bottleneck on pages with larger DOM size.
MR: !12103
Diffstat (limited to 'features')
| -rw-r--r-- | features/steps/shared/diff_note.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/features/steps/shared/diff_note.rb b/features/steps/shared/diff_note.rb index 36fc315599e..2c59ec5bb06 100644 --- a/features/steps/shared/diff_note.rb +++ b/features/steps/shared/diff_note.rb @@ -232,7 +232,7 @@ module SharedDiffNote end def click_parallel_diff_line(code, line_type) - find(".line_content.parallel.#{line_type}[data-line-code='#{code}']").trigger 'mouseover' + find(".line_holder.parallel .diff-line-num[id='#{code}']").trigger 'mouseover' find(".line_holder.parallel button[data-line-code='#{code}']").trigger 'click' end end |