diff options
author | Jeroen van Baarsen <jeroenvanbaarsen@gmail.com> | 2015-05-21 10:44:17 +0200 |
---|---|---|
committer | Jeroen van Baarsen <jeroenvanbaarsen@gmail.com> | 2015-05-28 10:45:22 +0200 |
commit | 3865a1d92585cb31864b5d0f1b325c3585b5c681 (patch) | |
tree | b578afdae51d5d4b140bd2b770b222c8bde309a7 /features | |
parent | 5322099464ffa5f39076678f648243168ccdc506 (diff) | |
download | gitlab-ce-3865a1d92585cb31864b5d0f1b325c3585b5c681.tar.gz |
Allow special characters in users bio
**What does this do?**
It removes the very strict sanitation on the users bio field, so that people can
have a bio like "I <3 GitLab"
**Why is this needed?**
Currently when you enter a bio with "I <3 GitLab", we only store "I ". This is
unexpected behaviour, since we want users to have a normal profile, without
having to worry what characters are allowed and which are not.
**Related issues:**
Fixes https://github.com/gitlabhq/gitlabhq/issues/5625
Signed-off-by: Jeroen van Baarsen <jeroenvanbaarsen@gmail.com>
Diffstat (limited to 'features')
-rw-r--r-- | features/steps/profile/profile.rb | 24 |
1 files changed, 13 insertions, 11 deletions
diff --git a/features/steps/profile/profile.rb b/features/steps/profile/profile.rb index 791982d16c3..1571ddbee39 100644 --- a/features/steps/profile/profile.rb +++ b/features/steps/profile/profile.rb @@ -7,21 +7,23 @@ class Spinach::Features::Profile < Spinach::FeatureSteps end step 'I change my profile info' do - fill_in "user_skype", with: "testskype" - fill_in "user_linkedin", with: "testlinkedin" - fill_in "user_twitter", with: "testtwitter" - fill_in "user_website_url", with: "testurl" - fill_in "user_location", with: "Ukraine" - click_button "Save changes" + fill_in 'user_skype', with: 'testskype' + fill_in 'user_linkedin', with: 'testlinkedin' + fill_in 'user_twitter', with: 'testtwitter' + fill_in 'user_website_url', with: 'testurl' + fill_in 'user_location', with: 'Ukraine' + fill_in 'user_bio', with: 'I <3 GitLab' + click_button 'Save changes' @user.reload end step 'I should see new profile info' do - @user.skype.should == 'testskype' - @user.linkedin.should == 'testlinkedin' - @user.twitter.should == 'testtwitter' - @user.website_url.should == 'testurl' - find("#user_location").value.should == "Ukraine" + expect(@user.skype).to eq 'testskype' + expect(@user.linkedin).to eq 'testlinkedin' + expect(@user.twitter).to eq 'testtwitter' + expect(@user.website_url).to eq 'testurl' + expect(@user.bio).to eq 'I <3 GitLab' + find('#user_location').value.should == 'Ukraine' end step 'I change my avatar' do |