diff options
| author | Rémy Coutable <remy@gitlab.com> | 2016-09-28 09:42:33 +0000 |
|---|---|---|
| committer | Ruben Davila <rdavila84@gmail.com> | 2016-09-28 10:57:12 -0500 |
| commit | fe93a9b4ecf52d7cf861f0fae95c27448d43c015 (patch) | |
| tree | a3b3af465b7d80a97097d38f4d1b47af277b1749 /features | |
| parent | 26b47b243acd2698db954b03f6d96d75e01152c0 (diff) | |
| download | gitlab-ce-fe93a9b4ecf52d7cf861f0fae95c27448d43c015.tar.gz | |
Merge branch '18028-respect-fork-project' into 'security'
Enforce the fork_project permission in Projects::CreateService
Projects::ForkService delegates to this service almost entirely, but needed one small change so it would propagate create errors correctly.
CreateService#execute needs significant refactoring; it is now right at the complexity limit set by Rubocop. I avoided doing so in this commit to keep the diff as small as possible.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/18028
See merge request !1996
Diffstat (limited to 'features')
| -rw-r--r-- | features/steps/project/fork.rb | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/features/steps/project/fork.rb b/features/steps/project/fork.rb index 8abeb5ee242..70dbd030003 100644 --- a/features/steps/project/fork.rb +++ b/features/steps/project/fork.rb @@ -70,6 +70,7 @@ class Spinach::Features::ProjectFork < Spinach::FeatureSteps step 'There is an existent fork of the "Shop" project' do user = create(:user, name: 'Mike') + @project.team << [user, :reporter] @forked_project = Projects::ForkService.new(@project, user).execute end |