diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-12-15 07:53:46 +0530 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-12-16 23:32:25 +0530 |
| commit | 3e1442766f3e2327e1e620b3b11623b09c35142b (patch) | |
| tree | 84ac7ec48795a2a6d3c1ce85caf91a9c410c4fd6 /lib/api/api.rb | |
| parent | a80ccec70687de2d7c53026fa25d7b85098cdb9a (diff) | |
| download | gitlab-ce-3e1442766f3e2327e1e620b3b11623b09c35142b.tar.gz | |
Implement review comments from @dbalexandre.
- Don't define "allowed environment variables" in two places.
- Dispatch to different arities of `Popen.open` without an if/else block.
- Use `described_class` instead of explicitly stating the class name within a
- spec.
- Remove `git_environment_variables_validator_spec` and keep the validation inline.
Diffstat (limited to 'lib/api/api.rb')
0 files changed, 0 insertions, 0 deletions