diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2016-12-16 22:39:52 +0530 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2016-12-16 23:32:25 +0530 |
| commit | e394d2872aa3a95d0e5cd13afe8e0de1ab01213a (patch) | |
| tree | 52134828c91f10bd81ff055510e2f7a9e1ce9e73 /lib/api/api.rb | |
| parent | 3e1442766f3e2327e1e620b3b11623b09c35142b (diff) | |
| download | gitlab-ce-e394d2872aa3a95d0e5cd13afe8e0de1ab01213a.tar.gz | |
Implement final review comments from @rymai.25301-git-2.11-force-push-bug
- `raise "string"` raises a `RuntimeError` - no need to be explicit
- Remove top-level comment in the `RevList` class
- Use `%w()` instead of `%w[]`
- Extract an `environment_variables` method to cache `env.slice(*ALLOWED_VARIABLES)`
- Use `start_with?` for env variable validation instead of regex match
- Validation specs for each allowed environment variable were identical. Build them dynamically.
- Minor change to `popen3` expectation.
Diffstat (limited to 'lib/api/api.rb')
0 files changed, 0 insertions, 0 deletions