diff options
author | Jacob Schatz <jschatz@gitlab.com> | 2016-08-25 15:40:11 +0000 |
---|---|---|
committer | Jacob Schatz <jschatz@gitlab.com> | 2016-08-25 15:40:11 +0000 |
commit | 871514f498e6ce8245c3f3ba647dc84be8a7fdfe (patch) | |
tree | bfb97b6d6a55cc4722ffc2fdba414a0d9814d793 /lib/api/api.rb | |
parent | 97c14167ba3685bcd2eba195d018aeb4012c3bf6 (diff) | |
parent | 33694a5a6465785c2fcd5c8217197070cbd7b316 (diff) | |
download | gitlab-ce-871514f498e6ce8245c3f3ba647dc84be8a7fdfe.tar.gz |
Merge branch 'standardize-cookie-paths' into 'master'
Ensure all javascripts use GitLab install directory as the cookie path.
## What does this MR do?
Fixes #20435 and standardizes all JavaScript-set cookies to use the same root url.
## Are there points in the code the reviewer needs to double check?
Nothing I can think of. This MR is pretty straight forward.
## Why was this MR needed?
Cookie paths were inconsistent across front-end scripts. Some would default to '/' and others had no set path and would end up tied to whatever page they were set on. Also as @connorshea noted, we cannot assume GitLab is installed at '/'.
Before:

After:

## What are the relevant issue numbers?
#20435
## Screenshots (if relevant)
see above
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- Tests
- [x] Added for this feature/bug
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5627
Diffstat (limited to 'lib/api/api.rb')
0 files changed, 0 insertions, 0 deletions