diff options
author | Fatih Acet <acetfatih@gmail.com> | 2016-08-31 20:01:58 +0000 |
---|---|---|
committer | Fatih Acet <acetfatih@gmail.com> | 2016-08-31 20:01:58 +0000 |
commit | 46b5fc2cf2e0a505b2678e224825d134f7a29e78 (patch) | |
tree | ef4fea247601d421e3819922cf4acfa882402ef6 /lib/api/files.rb | |
parent | bfdfd3ec4e3e6734e026c6c4ad55ca339f9767fa (diff) | |
parent | eba024366bdaa2d2645857fcb404ad0468b782fa (diff) | |
download | gitlab-ce-46b5fc2cf2e0a505b2678e224825d134f7a29e78.tar.gz |
Merge branch 'remove-redundant-js-timeago-pending' into 'master'
Remove redundant js-timeago-pending from user activity log
## What does this MR do?
Enables the `skip_js` feature of `time_ago_with_tooltip()` since the frontend was already re-initializing `timeago` on all the elements after it received the data from the backend.
## Are there points in the code the reviewer needs to double check?
Shouldn't be
## Why was this MR needed?
* Reduces bandwidth usage (Reduced by ~3.1kb)
* Removes redundant code
* Happy DOM :balloon:
## What are the relevant issue numbers?
Closes #21063
## Screenshots (if relevant)
Before (DOM):

After (DOM):

Before (Bandwidth):

After (Bandwidth):

## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
- Tests
- [x] All builds are passing
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if you do - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
See merge request !5871
Diffstat (limited to 'lib/api/files.rb')
0 files changed, 0 insertions, 0 deletions