diff options
| author | Stan Hu <stanhu@gmail.com> | 2019-03-02 09:31:36 -0800 |
|---|---|---|
| committer | Stan Hu <stanhu@gmail.com> | 2019-03-06 07:03:46 -0800 |
| commit | 062efe4f7a83fb2b6d951b314692cca9ee8731cd (patch) | |
| tree | 2907359acdf497130b38c75555056226189af829 /lib/api/issues.rb | |
| parent | a592a78072bb44fed1a25c25f2cabdc4cf4bc0bd (diff) | |
| download | gitlab-ce-062efe4f7a83fb2b6d951b314692cca9ee8731cd.tar.gz | |
Significantly reduce N+1 queries in /api/v4/todos endpoint
By preloading associations and batching issuable metadata lookups,
we can significantly cut the number of SQL queries needed to load
the Todos API endpoint.
On GitLab.com, my own tests showed my user's SQL queries went
from 365 to under 60 SQL queries.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/40378
Diffstat (limited to 'lib/api/issues.rb')
| -rw-r--r-- | lib/api/issues.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/api/issues.rb b/lib/api/issues.rb index f43f4d961d6..7b8c070ad57 100644 --- a/lib/api/issues.rb +++ b/lib/api/issues.rb @@ -28,7 +28,7 @@ module API args[:scope] = args[:scope].underscore if args[:scope] issues = IssuesFinder.new(current_user, args).execute - .preload(:assignees, :labels, :notes, :timelogs, :project, :author, :closed_by) + .with_api_entity_associations issues.reorder(order_options_with_tie_breaker) end # rubocop: enable CodeReuse/ActiveRecord |