diff options
| author | 🙈 jacopo beschi 🙉 <intrip@gmail.com> | 2018-04-18 09:19:40 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2018-04-18 09:19:40 +0000 |
| commit | c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e (patch) | |
| tree | 45c3fd39c83122eb602f217501924bc8d6899987 /lib/api/jobs.rb | |
| parent | 3529ccae9e3a484da5a4fba32bfdf0317f289363 (diff) | |
| download | gitlab-ce-c6b1043e9d1b7fe9912c330b6e7d4342f2a9694e.tar.gz | |
Resolve "Make a Rubocop that forbids returning from a block"
Diffstat (limited to 'lib/api/jobs.rb')
| -rw-r--r-- | lib/api/jobs.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/api/jobs.rb b/lib/api/jobs.rb index 60911c8d733..54d1acbd412 100644 --- a/lib/api/jobs.rb +++ b/lib/api/jobs.rb @@ -120,7 +120,7 @@ module API build = find_build!(params[:job_id]) authorize!(:update_build, build) - return forbidden!('Job is not retryable') unless build.retryable? + break forbidden!('Job is not retryable') unless build.retryable? build = Ci::Build.retry(build, current_user) @@ -138,7 +138,7 @@ module API build = find_build!(params[:job_id]) authorize!(:erase_build, build) - return forbidden!('Job is not erasable!') unless build.erasable? + break forbidden!('Job is not erasable!') unless build.erasable? build.erase(erased_by: current_user) present build, with: Entities::Job |