diff options
| author | Sebastian Ziebell <sebastian.ziebell@asquera.de> | 2013-02-27 17:50:30 +0100 |
|---|---|---|
| committer | Sebastian Ziebell <sebastian.ziebell@asquera.de> | 2013-02-27 17:50:30 +0100 |
| commit | 7499f65014257989510da50505fa7c0f5a4fae88 (patch) | |
| tree | b8c9355b73ec48c12bfa9d6416fa91ba4c4444e6 /lib/api/milestones.rb | |
| parent | 43d75960303be538fb79804ca6e2a90241aee0df (diff) | |
| download | gitlab-ce-7499f65014257989510da50505fa7c0f5a4fae88.tar.gz | |
API: extracted helper method to validate required parameters, code clean up
Added a helper method to check if required parameters are given in an API call. Can be used
to return a `400 Bad Request` return code if a required attribute is missing.
Code clean up and fixed tests.
Diffstat (limited to 'lib/api/milestones.rb')
| -rw-r--r-- | lib/api/milestones.rb | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/api/milestones.rb b/lib/api/milestones.rb index ff98f005180..1adeefece1f 100644 --- a/lib/api/milestones.rb +++ b/lib/api/milestones.rb @@ -41,8 +41,7 @@ module Gitlab # POST /projects/:id/milestones post ":id/milestones" do authorize! :admin_milestone, user_project - - bad_request!(:title) unless params[:title].present? + required_attributes! [:title] attrs = attributes_for_keys [:title, :description, :due_date] @milestone = user_project.milestones.new attrs |