diff options
| author | Kamil Trzciński <ayufan@ayufan.eu> | 2019-04-08 15:33:36 +0200 |
|---|---|---|
| committer | Kamil Trzciński <ayufan@ayufan.eu> | 2019-04-15 13:05:14 +0200 |
| commit | 650f40865e5d8136cb366fbde689c4100aafb0c5 (patch) | |
| tree | f740d9f235693ad8e2a3693d6ec30dee26d2a74a /lib/api/pipelines.rb | |
| parent | 7457c1e1229cd1e90e608e8b247e2fbb217f05b6 (diff) | |
| download | gitlab-ce-650f40865e5d8136cb366fbde689c4100aafb0c5.tar.gz | |
Forbid the use of `#reload` and prefer `#reset`forbid-the-usage-of-reload
The `#reload` makes to load all objects into memory,
and the main purpose of `#reload` is to drop the association cache.
The `#reset` seems to solve exactly that case.
Diffstat (limited to 'lib/api/pipelines.rb')
| -rw-r--r-- | lib/api/pipelines.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/api/pipelines.rb b/lib/api/pipelines.rb index f29a18e94cf..667bf1ec801 100644 --- a/lib/api/pipelines.rb +++ b/lib/api/pipelines.rb @@ -137,7 +137,7 @@ module API pipeline.cancel_running status 200 - present pipeline.reload, with: Entities::Pipeline + present pipeline.reset, with: Entities::Pipeline end end |