diff options
author | Stan Hu <stanhu@gmail.com> | 2018-01-26 22:16:56 -0800 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2018-01-30 21:46:09 -0800 |
commit | 46a6edc7314ce8acab5d8ce04799bd3557bc26bc (patch) | |
tree | 9b2d004d22a09ca51b4420feb87ca16d372da703 /lib/api/v3/members.rb | |
parent | 120c79020ddd3097ae64149c75864353276aaa5f (diff) | |
download | gitlab-ce-46a6edc7314ce8acab5d8ce04799bd3557bc26bc.tar.gz |
Remove N+1 queries with /projects/:project_id/{access_requests,members} API endpointssh-fix-project-members-api-perf
We can simplify the code quite a bit and improve performance by using
grape-entity merge fields:
https://github.com/ruby-grape/grape-entity/tree/v0.6.0#merge-fields
Relates to #42030
Diffstat (limited to 'lib/api/v3/members.rb')
-rw-r--r-- | lib/api/v3/members.rb | 15 |
1 files changed, 8 insertions, 7 deletions
diff --git a/lib/api/v3/members.rb b/lib/api/v3/members.rb index 46145cac7a5..d7bde8ceb89 100644 --- a/lib/api/v3/members.rb +++ b/lib/api/v3/members.rb @@ -22,10 +22,11 @@ module API get ":id/members" do source = find_source(source_type, params[:id]) - users = source.users - users = users.merge(User.search(params[:query])) if params[:query].present? + members = source.members.where.not(user_id: nil).includes(:user) + members = members.joins(:user).merge(User.search(params[:query])) if params[:query].present? + members = paginate(members) - present paginate(users), with: ::API::Entities::Member, source: source + present members, with: ::API::Entities::Member end desc 'Gets a member of a group or project.' do @@ -40,7 +41,7 @@ module API members = source.members member = members.find_by!(user_id: params[:user_id]) - present member.user, with: ::API::Entities::Member, member: member + present member, with: ::API::Entities::Member end desc 'Adds a member to a group or project.' do @@ -69,7 +70,7 @@ module API end if member.persisted? && member.valid? - present member.user, with: ::API::Entities::Member, member: member + present member, with: ::API::Entities::Member else # This is to ensure back-compatibility but 400 behavior should be used # for all validation errors in 9.0! @@ -93,7 +94,7 @@ module API member = source.members.find_by!(user_id: params.delete(:user_id)) if member.update_attributes(declared_params(include_missing: false)) - present member.user, with: ::API::Entities::Member, member: member + present member, with: ::API::Entities::Member else # This is to ensure back-compatibility but 400 behavior should be used # for all validation errors in 9.0! @@ -125,7 +126,7 @@ module API else ::Members::DestroyService.new(source, current_user, declared_params).execute - present member.user, with: ::API::Entities::Member, member: member + present member, with: ::API::Entities::Member end end end |