summaryrefslogtreecommitdiff
path: root/lib/api/v3
diff options
context:
space:
mode:
authorRobert Speicher <robert@gitlab.com>2018-01-18 23:10:19 +0000
committerRobert Speicher <rspeicher@gmail.com>2018-02-09 12:16:25 -0600
commitfec9fb05a5775b864ef6768df166d39fcb2be4bc (patch)
tree9274b1aba3720ae0204be7294000bb8f22b77a48 /lib/api/v3
parent603fa7c14193d37e3953225501d2108f0c581df5 (diff)
downloadgitlab-ce-fec9fb05a5775b864ef6768df166d39fcb2be4bc.tar.gz
Merge branch 'security-10-4-todo-api-reveals-sensitive-information' into 'security-10-4'
Restrict Todo API mark_as_done endpoint to the user's todos only
Diffstat (limited to 'lib/api/v3')
-rw-r--r--lib/api/v3/todos.rb2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/api/v3/todos.rb b/lib/api/v3/todos.rb
index 2f2cf259987..3e2c61f6dbd 100644
--- a/lib/api/v3/todos.rb
+++ b/lib/api/v3/todos.rb
@@ -12,7 +12,7 @@ module API
end
delete ':id' do
TodoService.new.mark_todos_as_done_by_ids(params[:id], current_user)
- todo = Todo.find(params[:id])
+ todo = current_user.todos.find(params[:id])
present todo, with: ::API::Entities::Todo, current_user: current_user
end