Remove Git circuit breaker

Was introduced in the time that GitLab still used NFS, which is not
required anymore in most cases. By removing this, the API it calls will
return empty responses. This interface has to be removed in the next
major release, expected to be 12.0.

2 files changed, 2 insertions, 21 deletions

diff --git a/lib/api/circuit_breakers.rb b/lib/api/circuit_breakers.rb
index 6eddc5e5b61..da756daadcc 100644
--- a/lib/api/circuit_breakers.rb
+++ b/lib/api/circuit_breakers.rb
@@ -13,37 +13,24 @@ module API
       end
       resource ':type' do
         namespace '', requirements: { type: 'repository_storage' } do
-          helpers do
-            def failing_storage_health
-              @failing_storage_health ||= Gitlab::Git::Storage::Health.for_failing_storages
-            end
-
-            def storage_health
-              @storage_health ||= Gitlab::Git::Storage::Health.for_all_storages
-            end
-          end
-
           desc 'Get all git storages' do
             detail 'This feature was introduced in GitLab 9.5'
-            success Entities::RepositoryStorageHealth
           end
           get do
-            present storage_health, with: Entities::RepositoryStorageHealth
+            present []
           end
 
           desc 'Get all failing git storages' do
             detail 'This feature was introduced in GitLab 9.5'
-            success Entities::RepositoryStorageHealth
           end
           get 'failing' do
-            present failing_storage_health, with: Entities::RepositoryStorageHealth
+            present []
           end
 
           desc 'Reset all storage failures and open circuitbreaker' do
             detail 'This feature was introduced in GitLab 9.5'
           end
           delete do
-            Gitlab::Git::Storage::FailureInfo.reset_all!
           end
         end
       end
diff --git a/lib/api/entities.rb b/lib/api/entities.rb
index 120545792f2..5a4b85f98cf 100644
--- a/lib/api/entities.rb
+++ b/lib/api/entities.rb
@@ -1364,12 +1364,6 @@ module API
       expose :submitted, as: :akismet_submitted
     end
 
-    class RepositoryStorageHealth < Grape::Entity
-      expose :storage_name
-      expose :failing_on_hosts
-      expose :total_failures
-    end
-
     class CustomAttribute < Grape::Entity
       expose :key
       expose :value