diff options
author | Yorick Peterse <yorickpeterse@gmail.com> | 2016-06-21 17:07:17 +0200 |
---|---|---|
committer | Yorick Peterse <yorickpeterse@gmail.com> | 2016-06-21 17:39:01 +0200 |
commit | d9a4ca5975b4fb91b147930d863f0bb4b9619a64 (patch) | |
tree | cadcad43926a1dfe08c71bb644a136127ae50796 /lib/banzai/renderer.rb | |
parent | 0468deafbd6fcf008eb672dd42b98390d95e8add (diff) | |
download | gitlab-ce-d9a4ca5975b4fb91b147930d863f0bb4b9619a64.tar.gz |
Move pre_process into render_resultremove-banzai-pre-process
The method Banzai::Renderer.pre_process would always be called,
regardless of whether the Markdown to render was already cached or not.
In cache the document _was_ cached the output of the pre-processing
pipeline was ignored resulting in it doing nothing but wasting CPU
cycles.
This commit moves Banzai::Renderer.pre_process into
Banzai::Renderer.render_result so that it's _only_ used when needed.
Diffstat (limited to 'lib/banzai/renderer.rb')
-rw-r--r-- | lib/banzai/renderer.rb | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/lib/banzai/renderer.rb b/lib/banzai/renderer.rb index c14a9c4c722..6718acdef7e 100644 --- a/lib/banzai/renderer.rb +++ b/lib/banzai/renderer.rb @@ -30,13 +30,9 @@ module Banzai end def self.render_result(text, context = {}) - Pipeline[context[:pipeline]].call(text, context) - end + text = Pipeline[:pre_process].to_html(text, context) if text - def self.pre_process(text, context) - pipeline = Pipeline[:pre_process] - - pipeline.to_html(text, context) + Pipeline[context[:pipeline]].call(text, context) end # Perform post-processing on an HTML String |