summaryrefslogtreecommitdiff
path: root/lib/bitbucket/client.rb
diff options
context:
space:
mode:
authorValery Sizov <valery@gitlab.com>2016-12-07 11:33:32 +0200
committerValery Sizov <valery@gitlab.com>2016-12-07 11:33:32 +0200
commit67b7637e5d7d3cf3e3f5cde6e7f984ece368c48c (patch)
tree2418c8d6c0c369023e75d89dec785a5d8f4c0dff /lib/bitbucket/client.rb
parent43b7b0ce23d4de7055dc1cdd660b92ff03f4eb1e (diff)
downloadgitlab-ce-67b7637e5d7d3cf3e3f5cde6e7f984ece368c48c.tar.gz
Apply review comments. Iteration 1
Diffstat (limited to 'lib/bitbucket/client.rb')
-rw-r--r--lib/bitbucket/client.rb29
1 files changed, 14 insertions, 15 deletions
diff --git a/lib/bitbucket/client.rb b/lib/bitbucket/client.rb
index 33e977d655d..9fa44506374 100644
--- a/lib/bitbucket/client.rb
+++ b/lib/bitbucket/client.rb
@@ -5,40 +5,39 @@ module Bitbucket
end
def issues(repo)
- relative_path = "/repositories/#{repo}/issues"
- paginator = Paginator.new(connection, relative_path, :issue)
+ path = "/repositories/#{repo}/issues"
+ paginator = Paginator.new(connection, path, :issue)
Collection.new(paginator)
end
- def issue_comments(repo, number)
- relative_path = "/repositories/#{repo}/issues/#{number}/comments"
- paginator = Paginator.new(connection, relative_path, :url)
+ def issue_comments(repo, issue_id)
+ path = "/repositories/#{repo}/issues/#{issue_id}/comments"
+ paginator = Paginator.new(connection, path, :url)
Collection.new(paginator).map do |comment_url|
- parsed_response = connection.get(comment_url.to_s)
- Representation::Comment.new(parsed_response)
+ Representation::Comment.new(connection.get(comment_url.to_s))
end
end
def pull_requests(repo)
- relative_path = "/repositories/#{repo}/pullrequests?state=ALL"
- paginator = Paginator.new(connection, relative_path, :pull_request)
+ path = "/repositories/#{repo}/pullrequests?state=ALL"
+ paginator = Paginator.new(connection, path, :pull_request)
Collection.new(paginator)
end
def pull_request_comments(repo, pull_request)
- relative_path = "/repositories/#{repo}/pullrequests/#{pull_request}/comments"
- paginator = Paginator.new(connection, relative_path, :pull_request_comment)
+ path = "/repositories/#{repo}/pullrequests/#{pull_request}/comments"
+ paginator = Paginator.new(connection, path, :pull_request_comment)
Collection.new(paginator)
end
def pull_request_diff(repo, pull_request)
- relative_path = "/repositories/#{repo}/pullrequests/#{pull_request}/diff"
+ path = "/repositories/#{repo}/pullrequests/#{pull_request}/diff"
- connection.get(relative_path)
+ connection.get(path)
end
def repo(name)
@@ -47,8 +46,8 @@ module Bitbucket
end
def repos
- relative_path = "/repositories/#{user.username}"
- paginator = Paginator.new(connection, relative_path, :repo)
+ path = "/repositories/#{user.username}"
+ paginator = Paginator.new(connection, path, :repo)
Collection.new(paginator)
end