diff options
| author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-06-23 10:07:42 +0200 |
|---|---|---|
| committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-06-23 10:22:41 +0200 |
| commit | 2240807c1aaa7d7df313dde9775e3ec99f7ad1b3 (patch) | |
| tree | a26d6a5eae3f89d12c4cb2cf0caf434733025a91 /lib/gitlab/ci/config/node/configurable.rb | |
| parent | bc2348f2e4365099e2a99df3d8e2a55fe7d138f4 (diff) | |
| download | gitlab-ce-2240807c1aaa7d7df313dde9775e3ec99f7ad1b3.tar.gz | |
Assume that unspecified CI config is undefined
We assume that when someone adds a key for the configuration entry, but
does not provide a valid value, which causes entry to be `nil`, then
entry should be considered as the undefined one. We also assume this is
semantically correct, this is also backwards compatible with legacy CI
config processor.
See issue #18775 for more details.
Diffstat (limited to 'lib/gitlab/ci/config/node/configurable.rb')
| -rw-r--r-- | lib/gitlab/ci/config/node/configurable.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/gitlab/ci/config/node/configurable.rb b/lib/gitlab/ci/config/node/configurable.rb index 25b5c2c9e21..0fb9092dafa 100644 --- a/lib/gitlab/ci/config/node/configurable.rb +++ b/lib/gitlab/ci/config/node/configurable.rb @@ -27,7 +27,6 @@ module Gitlab def create_node(key, factory) factory.with(value: @config[key], key: key) - factory.undefine! unless @config.has_key?(key) factory.create! end |