diff options
| author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-07-19 15:07:52 +0200 |
|---|---|---|
| committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-07-19 15:12:15 +0200 |
| commit | d6f669774481b160c2d963b56309ab6262216c42 (patch) | |
| tree | 0dd11b283a493370cebd07bf1e6f4bb316a10ad3 /lib/gitlab/ci | |
| parent | b6d3eadfe23997770ca260460c0e22fed6859d45 (diff) | |
| download | gitlab-ce-d6f669774481b160c2d963b56309ab6262216c42.tar.gz | |
Enable Rubocop cops for invalid access modifiersrubocop/enable-access-modifiers-cops
This enables following cops:
Check for useless access modifiers
Lint/UselessAccessModifier
Checks for attempts to use `private` or `protected` to set the
visibility of a class method, which does not work.
Lint/IneffectiveAccessModifier
This also disables two false possitives in concerns.
Diffstat (limited to 'lib/gitlab/ci')
| -rw-r--r-- | lib/gitlab/ci/config/node/configurable.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/gitlab/ci/config/node/configurable.rb b/lib/gitlab/ci/config/node/configurable.rb index 37936fc8242..2592e1ec244 100644 --- a/lib/gitlab/ci/config/node/configurable.rb +++ b/lib/gitlab/ci/config/node/configurable.rb @@ -36,7 +36,7 @@ module Gitlab Hash[(@nodes || {}).map { |key, factory| [key, factory.dup] }] end - private + private # rubocop:disable Lint/UselessAccessModifier def node(symbol, entry_class, metadata) factory = Node::Factory.new(entry_class) |