summaryrefslogtreecommitdiff
path: root/lib/gitlab/conflict
diff options
context:
space:
mode:
authorAlejandro Rodríguez <alejorro70@gmail.com>2017-12-12 22:55:30 -0300
committerAlejandro Rodríguez <alejorro70@gmail.com>2017-12-14 16:02:50 -0300
commit240945f87edf80e7f9a4e991b99fd4ade28aaabd (patch)
tree6e536b76bbe02b5db4d2cac85e89ff0c26256554 /lib/gitlab/conflict
parent31fa9313991881258b4697cb507cfc8ab205b7dc (diff)
downloadgitlab-ce-240945f87edf80e7f9a4e991b99fd4ade28aaabd.tar.gz
Simplify conflict resolver interfacegitaly-conflicts-prep
This does two things: - Pass commit oids instead of `Gitlab::Git::Commit`s. We only need the former. - Depend on only the target repository for conflict listing. For conflict resolution, treat one repository as a remote one so that we can implement it as such in Gitaly.
Diffstat (limited to 'lib/gitlab/conflict')
-rw-r--r--lib/gitlab/conflict/file_collection.rb6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/gitlab/conflict/file_collection.rb b/lib/gitlab/conflict/file_collection.rb
index b9099ce256a..76aee5a3deb 100644
--- a/lib/gitlab/conflict/file_collection.rb
+++ b/lib/gitlab/conflict/file_collection.rb
@@ -4,11 +4,11 @@ module Gitlab
attr_reader :merge_request, :resolver
def initialize(merge_request)
- source_repo = merge_request.source_project.repository.raw
our_commit = merge_request.source_branch_head.raw
their_commit = merge_request.target_branch_head.raw
target_repo = merge_request.target_project.repository.raw
- @resolver = Gitlab::Git::Conflict::Resolver.new(source_repo, our_commit, target_repo, their_commit)
+ @source_repo = merge_request.source_project.repository.raw
+ @resolver = Gitlab::Git::Conflict::Resolver.new(target_repo, our_commit.id, their_commit.id)
@merge_request = merge_request
end
@@ -18,7 +18,7 @@ module Gitlab
target_branch: merge_request.target_branch,
commit_message: commit_message || default_commit_message
}
- resolver.resolve_conflicts(user, files, args)
+ resolver.resolve_conflicts(@source_repo, user, files, args)
ensure
@merge_request.clear_memoized_shas
end