Report better errors. TODO: Enable skipped test

1 files changed, 9 insertions, 2 deletions

diff --git a/lib/gitlab/email/receiver.rb b/lib/gitlab/email/receiver.rb
index 471d10a11a6..50c16da4ef6 100644
--- a/lib/gitlab/email/receiver.rb
+++ b/lib/gitlab/email/receiver.rb
@@ -5,6 +5,7 @@ module Gitlab
       class ProcessingError < StandardError; end
       class EmailUnparsableError < ProcessingError; end
       class SentNotificationNotFoundError < ProcessingError; end
+      class ProjectNotFound < ProcessingError; end
       class EmptyEmailError < ProcessingError; end
       class AutoGeneratedEmailError < ProcessingError; end
       class UserNotFoundError < ProcessingError; end
@@ -25,10 +26,16 @@ module Gitlab
           process_create_note
 
         elsif message_project
-          process_create_issue
+          if message_sender.can?(:read_project, message_project)
+            process_create_issue
+          else # Must be private project without access
+            raise ProjectNotFound
+          end
 
+        elsif reply_key =~ %r{/|\+}
+          # Sent Notification reply_key would not have / or +
+          raise ProjectNotFound
         else
-          # TODO: could also be project not found
           raise SentNotificationNotFoundError
         end
       end