diff options
| author | Jacob Vosmaer (GitLab) <jacob@gitlab.com> | 2018-01-29 15:27:46 +0000 |
|---|---|---|
| committer | Robert Speicher <robert@gitlab.com> | 2018-01-29 15:27:46 +0000 |
| commit | e407c2d18f6558041a5bd54a568cfe52c1f3e3a4 (patch) | |
| tree | f133391bc6c053cb4af5c5483cf478eb672ab4da /lib/gitlab/git/repository.rb | |
| parent | 501d81c523b2cf53128e62ea2d7c4dff6681928d (diff) | |
| download | gitlab-ce-e407c2d18f6558041a5bd54a568cfe52c1f3e3a4.tar.gz | |
Don't allow Repository#log with limit zero
Diffstat (limited to 'lib/gitlab/git/repository.rb')
| -rw-r--r-- | lib/gitlab/git/repository.rb | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/lib/gitlab/git/repository.rb b/lib/gitlab/git/repository.rb index 64b491517cb..3a7930154e5 100644 --- a/lib/gitlab/git/repository.rb +++ b/lib/gitlab/git/repository.rb @@ -468,9 +468,13 @@ module Gitlab } options = default_options.merge(options) - options[:limit] ||= 0 options[:offset] ||= 0 + limit = options[:limit] + if limit == 0 || !limit.is_a?(Integer) + raise ArgumentError.new("invalid Repository#log limit: #{limit.inspect}") + end + gitaly_migrate(:find_commits) do |is_enabled| if is_enabled gitaly_commit_client.find_commits(options) |