diff options
author | Pawel Chojnacki <pawel@chojnacki.ws> | 2018-01-17 22:16:25 +0100 |
---|---|---|
committer | Pawel Chojnacki <pawel@chojnacki.ws> | 2018-01-29 15:13:04 +0100 |
commit | e3fe65543b9e660ba069899ae9e04fa9850b0f6c (patch) | |
tree | 21aa4fd2f139e5801cf208cb19cfc80da939a1c3 /lib/gitlab/metrics | |
parent | d7edc4b46b1f7a2389d4d0fb58aae9e4ff354535 (diff) | |
download | gitlab-ce-e3fe65543b9e660ba069899ae9e04fa9850b0f6c.tar.gz |
Add Tests for Metrics::Concern
Diffstat (limited to 'lib/gitlab/metrics')
-rw-r--r-- | lib/gitlab/metrics/concern.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/gitlab/metrics/concern.rb b/lib/gitlab/metrics/concern.rb index fa04aee78ba..6a05fb9b815 100644 --- a/lib/gitlab/metrics/concern.rb +++ b/lib/gitlab/metrics/concern.rb @@ -12,7 +12,7 @@ module Gitlab private def define_metric(type, name, opts = {}, &block) - if instance_methods(false).include?(name) + if respond_to?(name) raise ArgumentError, "metrics method #{name} already exists" end @@ -71,7 +71,7 @@ module Gitlab # @param [Symbol] name # @param [Hash] opts def fetch_gauge(name, opts = {}, &block) - fetch_metric(:counter, name, opts, &block) + fetch_metric(:gauge, name, opts, &block) end # Fetch and/or initialize histogram metric @@ -99,7 +99,7 @@ module Gitlab # @param [Symbol] name # @param [Hash] opts def define_gauge(name, opts = {}, &block) - define_metric(:counter, name, opts, &block) + define_metric(:gauge, name, opts, &block) end # Define metric accessor method for a Histogram |