diff options
| author | Jacob Vosmaer <contact@jacobvosmaer.nl> | 2014-02-25 12:12:09 +0100 |
|---|---|---|
| committer | Jacob Vosmaer <contact@jacobvosmaer.nl> | 2014-03-03 08:40:29 +0100 |
| commit | 2b816075dc71dfe8f6f9e5349fdff7f03ad9dad0 (patch) | |
| tree | 876e04b4c1a0d844fa1b1f023fd075ba521495ab /lib/gitlab/upgrader.rb | |
| parent | a9dcfd851f80c35522ac844b316af783d0db7e64 (diff) | |
| download | gitlab-ce-2b816075dc71dfe8f6f9e5349fdff7f03ad9dad0.tar.gz | |
Replace backticks with Gitlab::Popen
Diffstat (limited to 'lib/gitlab/upgrader.rb')
| -rw-r--r-- | lib/gitlab/upgrader.rb | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/gitlab/upgrader.rb b/lib/gitlab/upgrader.rb index f46685e4bbe..f17ad0d79cc 100644 --- a/lib/gitlab/upgrader.rb +++ b/lib/gitlab/upgrader.rb @@ -42,8 +42,9 @@ module Gitlab end def latest_version_raw - git_tags = `git ls-remote --tags origin | grep tags\/v#{current_version.major}` - git_tags = git_tags.lines.to_a.select { |version| version =~ /v\d\.\d\.\d\Z/ } + remote_tags, _ = Gitlab::Popen.popen(%W(git ls-remote --tags origin)) + git_tags = remote_tags.split("\n").grep(/tags\/v#{current_version.major}/) + git_tags = git_tags.select { |version| version =~ /v\d\.\d\.\d\Z/ } last_tag = git_tags.last.match(/v\d\.\d\.\d/).to_s end |