diff options
author | Stan Hu <stanhu@gmail.com> | 2018-09-05 21:41:59 -0700 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2018-09-05 22:04:23 -0700 |
commit | b1d04cf9d58ac461f70a2cbf4df617cc14c3de1c (patch) | |
tree | 4538b069e8910947efee8fe06093bc02d739a7b5 /lib/gitlab/url_blocker.rb | |
parent | ab22dae917cc38d6d9573fca472d09950fac8d08 (diff) | |
download | gitlab-ce-b1d04cf9d58ac461f70a2cbf4df617cc14c3de1c.tar.gz |
Block loopback addresses in UrlBlocker
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/51128
Diffstat (limited to 'lib/gitlab/url_blocker.rb')
-rw-r--r-- | lib/gitlab/url_blocker.rb | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/lib/gitlab/url_blocker.rb b/lib/gitlab/url_blocker.rb index 3b483f27e70..a2cce9151c3 100644 --- a/lib/gitlab/url_blocker.rb +++ b/lib/gitlab/url_blocker.rb @@ -30,6 +30,7 @@ module Gitlab end validate_localhost!(addrs_info) unless allow_localhost + validate_loopback!(addrs_info) unless allow_localhost validate_local_network!(addrs_info) unless allow_local_network validate_link_local!(addrs_info) unless allow_local_network @@ -84,6 +85,12 @@ module Gitlab raise BlockedUrlError, "Requests to localhost are not allowed" end + def validate_loopback!(addrs_info) + return unless addrs_info.any? { |addr| addr.ipv4_loopback? || addr.ipv6_loopback? } + + raise BlockedUrlError, "Requests to loopback addresses are not allowed" + end + def validate_local_network!(addrs_info) return unless addrs_info.any? { |addr| addr.ipv4_private? || addr.ipv6_sitelocal? } |