summaryrefslogtreecommitdiff
path: root/lib/gitlab
diff options
context:
space:
mode:
authorAndrew Newdigate <andrew@gitlab.com>2017-10-03 08:03:19 +0000
committerSean McGivern <sean@mcgivern.me.uk>2017-10-03 08:03:19 +0000
commit27cc1c2b2842a768ba631cf8418692bed8deb382 (patch)
tree5a74ffc5670d81c1a25afc1168e32da6df8a7e00 /lib/gitlab
parentd14230dd6b9bdd94577b1e52f810e143278ff80e (diff)
downloadgitlab-ce-27cc1c2b2842a768ba631cf8418692bed8deb382.tar.gz
Fix for Gitaly nil encoding issue
Diffstat (limited to 'lib/gitlab')
-rw-r--r--lib/gitlab/gitaly_client.rb2
-rw-r--r--lib/gitlab/gitaly_client/commit_service.rb2
2 files changed, 3 insertions, 1 deletions
diff --git a/lib/gitlab/gitaly_client.rb b/lib/gitlab/gitaly_client.rb
index e75e0500ed8..87b300dcf7e 100644
--- a/lib/gitlab/gitaly_client.rb
+++ b/lib/gitlab/gitaly_client.rb
@@ -233,6 +233,8 @@ module Gitlab
end
def self.encode(s)
+ return "" if s.nil?
+
s.dup.force_encoding(Encoding::ASCII_8BIT)
end
diff --git a/lib/gitlab/gitaly_client/commit_service.rb b/lib/gitlab/gitaly_client/commit_service.rb
index 36da63fd586..a2b50f2507e 100644
--- a/lib/gitlab/gitaly_client/commit_service.rb
+++ b/lib/gitlab/gitaly_client/commit_service.rb
@@ -274,7 +274,7 @@ module Gitlab
repository: @gitaly_repo,
left_commit_id: from_id,
right_commit_id: to_id,
- paths: options.fetch(:paths, []).map { |path| GitalyClient.encode(path) }
+ paths: options.fetch(:paths, []).compact.map { |path| GitalyClient.encode(path) }
}
end