summaryrefslogtreecommitdiff
path: root/lib/gitlab
diff options
context:
space:
mode:
authorGitLab Bot <gitlab-bot@gitlab.com>2022-06-29 14:16:15 +0000
committerGitLab Bot <gitlab-bot@gitlab.com>2022-06-29 14:16:15 +0000
commit5370ec1c3d27d646be672039e78161d22b1e2a80 (patch)
tree1c0ed695576be5560bb4399082f0642bc214f3f1 /lib/gitlab
parenta5baa12bfff6c41f6c9cf156edcf8e621f71848e (diff)
downloadgitlab-ce-5370ec1c3d27d646be672039e78161d22b1e2a80.tar.gz
Add latest changes from gitlab-org/security/gitlab@15-1-stable-ee
Diffstat (limited to 'lib/gitlab')
-rw-r--r--lib/gitlab/import_export/decompressed_archive_size_validator.rb20
1 files changed, 1 insertions, 19 deletions
diff --git a/lib/gitlab/import_export/decompressed_archive_size_validator.rb b/lib/gitlab/import_export/decompressed_archive_size_validator.rb
index a185eb4df1c..61b37256964 100644
--- a/lib/gitlab/import_export/decompressed_archive_size_validator.rb
+++ b/lib/gitlab/import_export/decompressed_archive_size_validator.rb
@@ -8,8 +8,6 @@ module Gitlab
DEFAULT_MAX_BYTES = 10.gigabytes.freeze
TIMEOUT_LIMIT = 210.seconds
- ServiceError = Class.new(StandardError)
-
def initialize(archive_path:, max_bytes: self.class.max_bytes)
@archive_path = archive_path
@max_bytes = max_bytes
@@ -31,8 +29,6 @@ module Gitlab
pgrp = nil
valid_archive = true
- validate_archive_path
-
Timeout.timeout(TIMEOUT_LIMIT) do
stdin, stdout, stderr, wait_thr = Open3.popen3(command, pgroup: true)
stdin.close
@@ -82,29 +78,15 @@ module Gitlab
false
end
- def validate_archive_path
- Gitlab::Utils.check_path_traversal!(@archive_path)
-
- raise(ServiceError, 'Archive path is not a string') unless @archive_path.is_a?(String)
- raise(ServiceError, 'Archive path is a symlink') if File.lstat(@archive_path).symlink?
- raise(ServiceError, 'Archive path is not a file') unless File.file?(@archive_path)
- end
-
def command
"gzip -dc #{@archive_path} | wc -c"
end
def log_error(error)
- archive_size = begin
- File.size(@archive_path)
- rescue StandardError
- nil
- end
-
Gitlab::Import::Logger.info(
message: error,
import_upload_archive_path: @archive_path,
- import_upload_archive_size: archive_size
+ import_upload_archive_size: File.size(@archive_path)
)
end
end