diff options
| author | Connor Shea <connor.james.shea@gmail.com> | 2018-02-28 15:58:12 -0700 |
|---|---|---|
| committer | Connor Shea <connor.james.shea@gmail.com> | 2018-02-28 15:58:12 -0700 |
| commit | 25283e71011490c674c54e64384957a692235e38 (patch) | |
| tree | 4d9bbed465e5978236a66f9a6fc081e933dcbdbc /lib/haml_lint/inline_javascript.rb | |
| parent | 83b3e9fa40571c7475bc803b15e9b57ad2dc36b8 (diff) | |
| download | gitlab-ce-25283e71011490c674c54e64384957a692235e38.tar.gz | |
Update inline_javascript.rb to lint uses of the javascript filter as well as script tags.
Diffstat (limited to 'lib/haml_lint/inline_javascript.rb')
| -rw-r--r-- | lib/haml_lint/inline_javascript.rb | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/lib/haml_lint/inline_javascript.rb b/lib/haml_lint/inline_javascript.rb index ff447513fd1..4f776330e80 100644 --- a/lib/haml_lint/inline_javascript.rb +++ b/lib/haml_lint/inline_javascript.rb @@ -6,7 +6,13 @@ unless Rails.env.production? module HamlLint class Linter::InlineJavaScript < Linter include LinterRegistry - + + def visit_filter(node) + return unless node.filter_type == 'javascript' + + record_lint(node, 'Inline JavaScript is discouraged (https://docs.gitlab.com/ee/development/gotchas.html#do-not-use-inline-javascript-in-views)') + end + def visit_tag(node) return unless node.tag_name == 'script' |