diff options
author | Gabriel Mazetto <brodock@gmail.com> | 2017-09-04 03:58:54 +0200 |
---|---|---|
committer | Gabriel Mazetto <brodock@gmail.com> | 2017-09-04 03:58:54 +0200 |
commit | 706d49b2590cfd70306f14cffdbadd237620a993 (patch) | |
tree | f337960dfb21e090224de21c84d5ad5bdc469cf8 /lib/system_check | |
parent | 6c21e6f91f2da28c0dea6bf3896055daede0a6e3 (diff) | |
download | gitlab-ce-706d49b2590cfd70306f14cffdbadd237620a993.tar.gz |
Added dynamic skip reason to SystemCheck
Diffstat (limited to 'lib/system_check')
-rw-r--r-- | lib/system_check/base_check.rb | 19 | ||||
-rw-r--r-- | lib/system_check/simple_executor.rb | 4 |
2 files changed, 21 insertions, 2 deletions
diff --git a/lib/system_check/base_check.rb b/lib/system_check/base_check.rb index 7f9e2ffffc2..0f5742dd67f 100644 --- a/lib/system_check/base_check.rb +++ b/lib/system_check/base_check.rb @@ -62,6 +62,25 @@ module SystemCheck call_or_return(@skip_reason) || 'skipped' end + # Define a reason why we skipped the SystemCheck (during runtime) + # + # This is used when you need dynamic evaluation like when you have + # multiple reasons why a check can fail + # + # @param [String] reason to be displayed + def skip_reason=(reason) + @skip_reason = reason + end + + # Skip reason defined during runtime + # + # This value have precedence over the one defined in the subclass + # + # @return [String] the reason + def skip_reason + @skip_reason + end + # Does the check support automatically repair routine? # # @return [Boolean] whether check implemented `#repair!` method or not diff --git a/lib/system_check/simple_executor.rb b/lib/system_check/simple_executor.rb index 6604b1078cf..00221f77cf4 100644 --- a/lib/system_check/simple_executor.rb +++ b/lib/system_check/simple_executor.rb @@ -23,7 +23,7 @@ module SystemCheck # # @param [BaseCheck] check class def <<(check) - raise ArgumentError unless check < BaseCheck + raise ArgumentError unless check.is_a?(Class) && check < BaseCheck @checks << check end @@ -48,7 +48,7 @@ module SystemCheck # When implements skip method, we run it first, and if true, skip the check if check.can_skip? && check.skip? - $stdout.puts check_klass.skip_reason.color(:magenta) + $stdout.puts check.skip_reason.try(:color, :magenta) || check_klass.skip_reason.color(:magenta) return end |