diff options
author | Timothy Andrew <mail@timothyandrew.net> | 2017-06-30 16:36:36 +0000 |
---|---|---|
committer | Timothy Andrew <mail@timothyandrew.net> | 2017-07-06 06:30:07 +0000 |
commit | 8fa08ea3cd81e906c4f4951c70e3571defeab7c7 (patch) | |
tree | 9f74b9cb3479e5b69db86f6ddd3ba32d30c2e7a2 /lib/tasks | |
parent | 56754848dddb5460500ab056e5ac1b9a61c7ff89 (diff) | |
download | gitlab-ce-8fa08ea3cd81e906c4f4951c70e3571defeab7c7.tar.gz |
Implement review comments for !11963 from @adamniedzielski.
- Change double quotes to single quotes.
- Why is `OmniAuth.config.full_host` being reassigned in the integration test?
- Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task
- Other minor changes
Diffstat (limited to 'lib/tasks')
-rw-r--r-- | lib/tasks/gitlab/info.rake | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/tasks/gitlab/info.rake b/lib/tasks/gitlab/info.rake index 2245dfb7828..e9fb6a008b0 100644 --- a/lib/tasks/gitlab/info.rake +++ b/lib/tasks/gitlab/info.rake @@ -42,8 +42,7 @@ namespace :gitlab do http_clone_url = project.http_url_to_repo ssh_clone_url = project.ssh_url_to_repo - omniauth_providers = Gitlab.config.omniauth.providers.dup - omniauth_providers.map! { |provider| provider['name'] } + omniauth_providers = Gitlab.config.omniauth.providers.map { |provider| provider['name'] } puts "" puts "GitLab information".color(:yellow) |