diff options
| author | Z.J. van de Weg <zegerjan@gitlab.com> | 2016-08-18 11:42:37 +0200 |
|---|---|---|
| committer | Z.J. van de Weg <zegerjan@gitlab.com> | 2016-08-18 21:10:53 +0200 |
| commit | ba01e519e24bf716c138a0b46e371c60de4aa935 (patch) | |
| tree | 1021901a6a273f940e480914562ae59e4f35a31d /lib | |
| parent | 182e28141d2e1ac904590a431ed7249d4c20984b (diff) | |
| download | gitlab-ce-ba01e519e24bf716c138a0b46e371c60de4aa935.tar.gz | |
Incorporate feedback
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/api/builds.rb | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/lib/api/builds.rb b/lib/api/builds.rb index 2bd3b65acdc..52bdbcae5a8 100644 --- a/lib/api/builds.rb +++ b/lib/api/builds.rb @@ -202,15 +202,13 @@ module API build = get_build!(params[:build_id]) - if build.playable? - build.play(current_user) + bad_request!("Unplayable Build") unless build.playable? - status 200 - present build, with: Entities::Build, - user_can_download_artifacts: can?(current_user, :read_build, user_project) - else - bad_request!("Unplayable Build") - end + build.play(current_user) + + status 200 + present build, with: Entities::Build, + user_can_download_artifacts: can?(current_user, :read_build, user_project) end end |