diff options
| author | Yorick Peterse <yorickpeterse@gmail.com> | 2016-07-20 20:13:02 +0200 |
|---|---|---|
| committer | Yorick Peterse <yorickpeterse@gmail.com> | 2016-07-29 12:51:18 +0200 |
| commit | 002ad215818450d2cbbc5fa065850a953dc7ada8 (patch) | |
| tree | 9ac1703e56bd460fd24c7a5c93a5c465a83127b7 /lib | |
| parent | 9b0e131b83cfc44d3132bddfefb6cbd4bff7d253 (diff) | |
| download | gitlab-ce-002ad215818450d2cbbc5fa065850a953dc7ada8.tar.gz | |
Method for returning issues readable by a userability-batch-issue-checking
The method Ability.issues_readable_by_user takes a list of users and an
optional user and returns an Array of issues readable by said user. This
method in turn is used by
Banzai::ReferenceParser::IssueParser#nodes_visible_to_user so this
method no longer needs to get all the available abilities just to check
if a user has the "read_issue" ability.
To test this I benchmarked an issue with 222 comments on my development
environment. Using these changes the time spent in nodes_visible_to_user
was reduced from around 120 ms to around 40 ms.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/banzai/reference_parser/issue_parser.rb | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/lib/banzai/reference_parser/issue_parser.rb b/lib/banzai/reference_parser/issue_parser.rb index f306079d833..6c20dec5734 100644 --- a/lib/banzai/reference_parser/issue_parser.rb +++ b/lib/banzai/reference_parser/issue_parser.rb @@ -9,10 +9,11 @@ module Banzai issues = issues_for_nodes(nodes) - nodes.select do |node| - issue = issue_for_node(issues, node) + readable_issues = Ability. + issues_readable_by_user(issues.values, user).to_set - issue ? can?(user, :read_issue, issue) : false + nodes.select do |node| + readable_issues.include?(issue_for_node(issues, node)) end end |