diff options
author | Stan Hu <stanhu@gmail.com> | 2019-06-08 07:12:47 -0700 |
---|---|---|
committer | Stan Hu <stanhu@gmail.com> | 2019-06-08 08:04:44 -0700 |
commit | 350f19f59fd1e44c18699cc46cfff71a92d7e0a4 (patch) | |
tree | b4aa7849dc1e297493589ee2739f490ba9fd751a /lib | |
parent | 2a01cb79560a861a7e32e9ee11e823f22e181aa1 (diff) | |
download | gitlab-ce-350f19f59fd1e44c18699cc46cfff71a92d7e0a4.tar.gz |
Bump omniauth_openid_connect to 0.3.1sh-update-openid-omniauth-gem
In https://gitlab.com/gitlab-org/gitlab-ce/issues/62208, users were
seeing 404 errors when they configured their OpenID provider without a
name parameter since OmniAuth would use the name `openidconnect` instead
`openid_connect`.
https://github.com/m0n9oose/omniauth_openid_connect/pull/23 makes the
default parameter `openid_connect` so this additional initializer in
GitLab is not necessary. Plus, this change enables users to use multiple
OpenID Connect providers if they desire.
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab/omniauth_initializer.rb | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/lib/gitlab/omniauth_initializer.rb b/lib/gitlab/omniauth_initializer.rb index 83204fa5d18..2a2083ebae0 100644 --- a/lib/gitlab/omniauth_initializer.rb +++ b/lib/gitlab/omniauth_initializer.rb @@ -63,12 +63,6 @@ module Gitlab { remote_sign_out_handler: authentiq_signout_handler } when 'shibboleth' { fail_with_empty_uid: true } - when 'openid_connect' - # If a name argument is omitted, OmniAuth will expect that the - # matching route is /auth/users/openidconnect instead of - # /auth/users/openid_connect because of - # https://gitlab.com/gitlab-org/gitlab-ce/issues/62208#note_178780341. - { name: 'openid_connect' } else {} end |