diff options
| author | Timothy Andrew <mail@timothyandrew.net> | 2017-06-20 03:11:16 +0000 |
|---|---|---|
| committer | Timothy Andrew <mail@timothyandrew.net> | 2017-07-03 16:25:10 +0000 |
| commit | 1652e68a6d18bb7a44e73e713aae5c581c980b2c (patch) | |
| tree | f2046ab371238497be470cc4f340a21837aedc10 /lib | |
| parent | c9da377ded1bd189a706e72c69ee05f2fd6a4523 (diff) | |
| download | gitlab-ce-1652e68a6d18bb7a44e73e713aae5c581c980b2c.tar.gz | |
Don't allow the `gitlab:env:info` rake task to mutate the list of omniauth providers.
- The test for `rake gitlab:env:info` executed the rake task, which mutated the
list of omniauth providers, breaking subsequent tests relying on this list.
- I've changed the rake task to duplicate the providers list before modifying it.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/tasks/gitlab/info.rake | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/tasks/gitlab/info.rake b/lib/tasks/gitlab/info.rake index e3883278886..2245dfb7828 100644 --- a/lib/tasks/gitlab/info.rake +++ b/lib/tasks/gitlab/info.rake @@ -42,7 +42,7 @@ namespace :gitlab do http_clone_url = project.http_url_to_repo ssh_clone_url = project.ssh_url_to_repo - omniauth_providers = Gitlab.config.omniauth.providers + omniauth_providers = Gitlab.config.omniauth.providers.dup omniauth_providers.map! { |provider| provider['name'] } puts "" |