project_from_ref returns nil when reference doesn't exist.

1 files changed, 6 insertions, 9 deletions

diff --git a/lib/gitlab/markdown/cross_project_reference.rb b/lib/gitlab/markdown/cross_project_reference.rb
index de05102751f..887c205cdc9 100644
--- a/lib/gitlab/markdown/cross_project_reference.rb
+++ b/lib/gitlab/markdown/cross_project_reference.rb
@@ -16,15 +16,12 @@ module Gitlab
       #
       # Returns a Project, or nil if the reference can't be accessed
       def project_from_ref(ref)
-        if ref && other = Project.find_with_namespace(ref)
-          if user_can_reference_project?(other)
-            other
-          else
-            nil
-          end
-        else
-          context[:project]
-        end
+        return context[:project] unless ref
+
+        other = Project.find_with_namespace(ref)
+        return nil unless other && user_can_reference_project?(other)
+        
+        other
       end
 
       def user_can_reference_project?(project, user = context[:current_user])