Hide 'peek' by using 'performance bar' instead

Signed-off-by: Rémy Coutable <remy@rymai.me>

2 files changed, 7 insertions, 12 deletions

diff --git a/lib/feature.rb b/lib/feature.rb
index 853a00c75a4..5470c2802d5 100644
--- a/lib/feature.rb
+++ b/lib/feature.rb
@@ -54,15 +54,13 @@ class Feature
         adapter = Flipper::Adapters::ActiveRecord.new(
           feature_class: FlipperFeature, gate_class: FlipperGate)
 
-        Flipper.new(adapter).tap do
-          register_feature_groups
-        end
+        Flipper.new(adapter)
       end
     end
 
     def register_feature_groups
       Flipper.register(:performance_team) do |actor|
-        Gitlab::PerformanceBar.allowed_actor?(actor)
+        actor.thing&.is_a?(User) && Gitlab::PerformanceBar.allowed_user?(actor.thing)
       end
     end
   end
diff --git a/lib/gitlab/performance_bar.rb b/lib/gitlab/performance_bar.rb
index 53812633888..af73cae3c9f 100644
--- a/lib/gitlab/performance_bar.rb
+++ b/lib/gitlab/performance_bar.rb
@@ -4,15 +4,15 @@ module Gitlab
       Feature.enabled?(:gitlab_performance_bar, current_user)
     end
 
-    def self.allowed_actor?(actor)
-      return false unless actor.thing&.is_a?(User) && allowed_group
+    def self.allowed_user?(user)
+      return false unless allowed_group
 
       if RequestStore.active?
         RequestStore.fetch('performance_bar:user_member_of_allowed_group') do
-          user_member_of_allowed_group?(actor.thing)
+          user_member_of_allowed_group?(user)
         end
       else
-        user_member_of_allowed_group?(actor.thing)
+        user_member_of_allowed_group?(user)
       end
     end
 
@@ -29,10 +29,7 @@ module Gitlab
     end
 
     def self.user_member_of_allowed_group?(user)
-      GroupMembersFinder.new(allowed_group)
-        .execute
-        .where(user_id: user.id)
-        .any?
+      GroupMembersFinder.new(allowed_group).execute.exists?(user_id: user.id)
     end
   end
 end