diff options
author | Robert Schilling <rschilling@student.tugraz.at> | 2017-02-24 20:13:27 +0100 |
---|---|---|
committer | Robert Schilling <rschilling@student.tugraz.at> | 2017-02-24 20:13:27 +0100 |
commit | 0394055112fc0fe947aa13bc049f03a0dc1db0d1 (patch) | |
tree | 186fdd2fd73af7f6c2c7412dd0c4a3016bad8cdc /lib | |
parent | 52ceaa2406d48151c4158efd46032767bdd8ad1c (diff) | |
download | gitlab-ce-0394055112fc0fe947aa13bc049f03a0dc1db0d1.tar.gz |
API: Return 400 for all validation erros in the mebers APIunified-member-api-response
Diffstat (limited to 'lib')
-rw-r--r-- | lib/api/members.rb | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/lib/api/members.rb b/lib/api/members.rb index 8360c007005..5f6913d1a27 100644 --- a/lib/api/members.rb +++ b/lib/api/members.rb @@ -55,7 +55,6 @@ module API authorize_admin_source!(source_type, source) member = source.members.find_by(user_id: params[:user_id]) - conflict!('Member already exists') if member member = source.add_user(params[:user_id], params[:access_level], current_user: current_user, expires_at: params[:expires_at]) @@ -63,9 +62,6 @@ module API if member.persisted? && member.valid? present member.user, with: Entities::Member, member: member else - # This is to ensure back-compatibility but 400 behavior should be used - # for all validation errors in 9.0! - render_api_error!('Access level is not known', 422) if member.errors.key?(:access_level) render_validation_error!(member) end end @@ -87,9 +83,6 @@ module API if member.update_attributes(declared_params(include_missing: false)) present member.user, with: Entities::Member, member: member else - # This is to ensure back-compatibility but 400 behavior should be used - # for all validation errors in 9.0! - render_api_error!('Access level is not known', 422) if member.errors.key?(:access_level) render_validation_error!(member) end end |