diff options
| author | Rémy Coutable <remy@rymai.me> | 2019-01-16 11:05:36 +0000 |
|---|---|---|
| committer | Rémy Coutable <remy@rymai.me> | 2019-01-16 11:05:36 +0000 |
| commit | 8c5c8ec1bd213b1dbad68cac0e22c6709744b96b (patch) | |
| tree | 89ce08f4b1446e373e37bd4b822ce6bbfa18abef /lib | |
| parent | 4725ae2b2e511ee29be9c4b4a47bb1632b5cf6be (diff) | |
| parent | c379973bceccbcd7b554f4a9c7026aca7cba4618 (diff) | |
| download | gitlab-ce-8c5c8ec1bd213b1dbad68cac0e22c6709744b96b.tar.gz | |
Merge branch 'fix-trivial-accessors' into 'master'
chore(rubocop): fix Style/TrivialAccessors issues
See merge request gitlab-org/gitlab-ce!24416
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/gitlab/auth/ldap/person.rb | 4 | ||||
| -rw-r--r-- | lib/system_check/base_check.rb | 8 |
2 files changed, 3 insertions, 9 deletions
diff --git a/lib/gitlab/auth/ldap/person.rb b/lib/gitlab/auth/ldap/person.rb index a0244a3cea1..48d134f91b0 100644 --- a/lib/gitlab/auth/ldap/person.rb +++ b/lib/gitlab/auth/ldap/person.rb @@ -98,9 +98,7 @@ module Gitlab private - def entry - @entry - end + attr_reader :entry def config @config ||= Gitlab::Auth::LDAP::Config.new(provider) diff --git a/lib/system_check/base_check.rb b/lib/system_check/base_check.rb index e06245294c4..46aad8aa885 100644 --- a/lib/system_check/base_check.rb +++ b/lib/system_check/base_check.rb @@ -70,18 +70,14 @@ module SystemCheck # multiple reasons why a check can fail # # @param [String] reason to be displayed - def skip_reason=(reason) - @skip_reason = reason - end + attr_writer :skip_reason # Skip reason defined during runtime # # This value have precedence over the one defined in the subclass # # @return [String] the reason - def skip_reason - @skip_reason - end + attr_reader :skip_reason # Does the check support automatically repair routine? # |