diff options
author | Rémy Coutable <remy@rymai.me> | 2016-12-20 09:45:37 +0100 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2016-12-20 09:45:37 +0100 |
commit | 212967aefb55e0792a36e67a881b66c8bd871e9f (patch) | |
tree | 0dff682d6403318633ce9dddc4a119ead7294839 /lib | |
parent | c1dbae90033c10bef1aaa3c5c34219c1d0e5ef61 (diff) | |
download | gitlab-ce-212967aefb55e0792a36e67a881b66c8bd871e9f.tar.gz |
Reject blank environment vcariables in Gitlab::Git::RevList25848-fix-git-rev-list-env-parsing
Signed-off-by: Rémy Coutable <remy@rymai.me>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab/git/rev_list.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/gitlab/git/rev_list.rb b/lib/gitlab/git/rev_list.rb index 25e9d619697..79dd0cf7df2 100644 --- a/lib/gitlab/git/rev_list.rb +++ b/lib/gitlab/git/rev_list.rb @@ -22,7 +22,7 @@ module Gitlab def valid? environment_variables.all? do |(name, value)| - value.start_with?(project.repository.path_to_repo) + value.to_s.start_with?(project.repository.path_to_repo) end end @@ -35,7 +35,7 @@ module Gitlab end def environment_variables - @environment_variables ||= env.slice(*ALLOWED_VARIABLES) + @environment_variables ||= env.slice(*ALLOWED_VARIABLES).compact end end end |