diff options
author | Shinya Maeda <shinya@gitlab.com> | 2018-06-03 15:13:36 +0900 |
---|---|---|
committer | Shinya Maeda <shinya@gitlab.com> | 2018-06-04 14:14:20 +0900 |
commit | 2184c753fd81925c74a3a30abe9be187aa8c4133 (patch) | |
tree | 5ed9c9e79cfb5613cc7fba77b1a1e0920cb5005e /lib | |
parent | 623accf9cb3babb81d789a013e6ad87ad0bf26e5 (diff) | |
download | gitlab-ce-2184c753fd81925c74a3a30abe9be187aa8c4133.tar.gz |
Revise comments in ArchiveLegacyTraces
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab/background_migration/archive_legacy_traces.rb | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/gitlab/background_migration/archive_legacy_traces.rb b/lib/gitlab/background_migration/archive_legacy_traces.rb index 0999ea95e56..5a4e5b2c471 100644 --- a/lib/gitlab/background_migration/archive_legacy_traces.rb +++ b/lib/gitlab/background_migration/archive_legacy_traces.rb @@ -6,10 +6,10 @@ module Gitlab module BackgroundMigration class ArchiveLegacyTraces def perform(start_id, stop_id) - # This background migrations directly refer ::Ci::Build model which is defined in application code. + # This background migration directly refers to ::Ci::Build model which is defined in application code. # In general, migration code should be isolated as much as possible in order to be idempotent. - # However, `archive!` logic is too complicated to be replicated. So we chose a way to refer ::Ci::Build directly - # and we don't change the `archive!` logic until 11.1 + # However, `archive!` method is too complicated to be replicated by coping its subsequent code. + # So we chose a way to use ::Ci::Build directly and we don't change the `archive!` method until 11.1 ::Ci::Build.finished.without_archived_trace .where(id: start_id..stop_id).find_each do |build| begin |