summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorStan Hu <stanhu@gmail.com>2019-08-17 00:42:23 -0700
committerStan Hu <stanhu@gmail.com>2019-08-17 06:23:26 -0700
commitb46b9d5e89d54cf1e374a014f0d523735c82ab8c (patch)
treea0b9cf862aa38839b4f1b4d5a8828b3d9078efe4 /lib
parent1068483f7260e5866c7d54f1f09b716dbf463c80 (diff)
downloadgitlab-ce-b46b9d5e89d54cf1e374a014f0d523735c82ab8c.tar.gz
Fix pipelines not always being created after a pushsh-fix-pipelines-not-being-created
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31741 introduced a regression where not all the right parameters would be passed into `Ci::CreatePipelineService`. We fix this by breaking out the pipeline parameters and reusing a method from `Gitlab::DataBuilder::Push`. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/66196
Diffstat (limited to 'lib')
-rw-r--r--lib/gitlab/data_builder/push.rb2
1 files changed, 0 insertions, 2 deletions
diff --git a/lib/gitlab/data_builder/push.rb b/lib/gitlab/data_builder/push.rb
index 37fadb47736..75d9a2d55b9 100644
--- a/lib/gitlab/data_builder/push.rb
+++ b/lib/gitlab/data_builder/push.rb
@@ -129,8 +129,6 @@ module Gitlab
SAMPLE_DATA
end
- private
-
def checkout_sha(repository, newrev, ref)
# Checkout sha is nil when we remove branch or tag
return if Gitlab::Git.blank_ref?(newrev)