diff options
author | Rémy Coutable <remy@rymai.me> | 2018-09-27 10:28:27 +0000 |
---|---|---|
committer | Rémy Coutable <remy@rymai.me> | 2018-09-27 10:28:27 +0000 |
commit | 2b5aa3efb86261e315ee770f95c111eb9b4bc416 (patch) | |
tree | 4e6d6ffc7818379b96135a603b4b32255a6e5e00 /lib | |
parent | d5bce06df1ec36371db208d0aaf42d849eb63bcf (diff) | |
parent | 271776d4aa25a23b6f58c6befa94a240e61d4120 (diff) | |
download | gitlab-ce-2b5aa3efb86261e315ee770f95c111eb9b4bc416.tar.gz |
Merge branch '43832-adds-chdmod-to-commits-actions-api' into 'master'
Allows to work with execute permissions in GitLab API
Closes #43832
See merge request gitlab-org/gitlab-ce!21866
Diffstat (limited to 'lib')
-rw-r--r-- | lib/api/commits.rb | 21 | ||||
-rw-r--r-- | lib/gitlab/gitaly_client/operation_service.rb | 3 |
2 files changed, 22 insertions, 2 deletions
diff --git a/lib/api/commits.rb b/lib/api/commits.rb index fcaff35459e..5aeffc8fb99 100644 --- a/lib/api/commits.rb +++ b/lib/api/commits.rb @@ -73,7 +73,26 @@ module API params do requires :branch, type: String, desc: 'Name of the branch to commit into. To create a new branch, also provide `start_branch`.', allow_blank: false requires :commit_message, type: String, desc: 'Commit message' - requires :actions, type: Array[Hash], desc: 'Actions to perform in commit' + requires :actions, type: Array, desc: 'Actions to perform in commit' do + requires :action, type: String, desc: 'The action to perform, `create`, `delete`, `move`, `update`, `chmod`', values: %w[create update move delete chmod].freeze + requires :file_path, type: String, desc: 'Full path to the file. Ex. `lib/class.rb`' + given action: ->(action) { action == 'move' } do + requires :previous_path, type: String, desc: 'Original full path to the file being moved. Ex. `lib/class1.rb`' + end + given action: ->(action) { %w[create move].include? action } do + optional :content, type: String, desc: 'File content' + end + given action: ->(action) { action == 'update' } do + requires :content, type: String, desc: 'File content' + end + optional :encoding, type: String, desc: '`text` or `base64`', default: 'text', values: %w[text base64] + given action: ->(action) { %w[update move delete].include? action } do + optional :last_commit_id, type: String, desc: 'Last known file commit id' + end + given action: ->(action) { action == 'chmod' } do + requires :execute_filemode, type: Boolean, desc: 'When `true/false` enables/disables the execute flag on the file.' + end + end optional :start_branch, type: String, desc: 'Name of the branch to start the new commit from' optional :author_email, type: String, desc: 'Author email for commit' optional :author_name, type: String, desc: 'Author name for commit' diff --git a/lib/gitlab/gitaly_client/operation_service.rb b/lib/gitlab/gitaly_client/operation_service.rb index 54c78fdb680..0f148614b20 100644 --- a/lib/gitlab/gitaly_client/operation_service.rb +++ b/lib/gitlab/gitaly_client/operation_service.rb @@ -333,7 +333,8 @@ module Gitlab action: action[:action].upcase.to_sym, file_path: encode_binary(action[:file_path]), previous_path: encode_binary(action[:previous_path]), - base64_content: action[:encoding] == 'base64' + base64_content: action[:encoding] == 'base64', + execute_filemode: !!action[:execute_filemode] ) rescue RangeError raise ArgumentError, "Unknown action '#{action[:action]}'" |