diff options
author | Francisco Javier López <fjlopez@gitlab.com> | 2019-02-27 14:20:26 +0000 |
---|---|---|
committer | Yorick Peterse <yorickpeterse@gmail.com> | 2019-02-27 14:20:26 +0000 |
commit | a624cec9aefeb78a010a48cc99baa9e5d40df3a0 (patch) | |
tree | 2afde0f9120d900b42dd2848151f8e41dd12b3e6 /lib | |
parent | 86363c20cfcd924fe82654c2b41ae2d7f359a09e (diff) | |
download | gitlab-ce-a624cec9aefeb78a010a48cc99baa9e5d40df3a0.tar.gz |
Arbitrary file read via MergeRequestDiff
Diffstat (limited to 'lib')
-rw-r--r-- | lib/gitlab/import_export/merge_request_parser.rb | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/lib/gitlab/import_export/merge_request_parser.rb b/lib/gitlab/import_export/merge_request_parser.rb index 040a70d6775..deb2f59f05f 100644 --- a/lib/gitlab/import_export/merge_request_parser.rb +++ b/lib/gitlab/import_export/merge_request_parser.rb @@ -20,6 +20,17 @@ module Gitlab create_target_branch unless branch_exists?(@merge_request.target_branch) end + # The merge_request_diff associated with the current @merge_request might + # be invalid. Than means, when the @merge_request object is saved, the + # @merge_request.merge_request_diff won't. This can leave the merge request + # in an invalid state, because a merge request must have an associated + # merge request diff. + # In this change, if the associated merge request diff is invalid, we set + # it to nil. This change, in association with the after callback + # :ensure_merge_request_diff in the MergeRequest class, makes that + # when the merge request is going to be created and it doesn't have + # one, a default one will be generated. + @merge_request.merge_request_diff = nil unless @merge_request.merge_request_diff&.valid? @merge_request end |