diff options
| author | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-05-22 23:31:33 +0200 |
|---|---|---|
| committer | Grzegorz Bizon <grzesiek.bizon@gmail.com> | 2016-05-22 23:31:33 +0200 |
| commit | 7f9092da1e349c51af9febaa4db4995c851ef2d2 (patch) | |
| tree | b6dd007315f4923d8fdcdc66a41a761a9179f936 /lib | |
| parent | 2df8b48dbbe57f64d414e7c3395f9d34b01271b0 (diff) | |
| download | gitlab-ce-7f9092da1e349c51af9febaa4db4995c851ef2d2.tar.gz | |
Extend comment for migrations helper MySQL fix
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/gitlab/database/migration_helpers.rb | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/lib/gitlab/database/migration_helpers.rb b/lib/gitlab/database/migration_helpers.rb index 1fe6c1143d5..fd14234c558 100644 --- a/lib/gitlab/database/migration_helpers.rb +++ b/lib/gitlab/database/migration_helpers.rb @@ -39,7 +39,14 @@ module Gitlab def update_column_in_batches(table, column, value) quoted_table = quote_table_name(table) quoted_column = quote_column_name(column) - # workaround for #17711 + + ## + # Workaround for #17711 + # + # It looks like for MySQL `ActiveRecord::Base.conntection.quote(true)` + # returns correct value (1), but `ActiveRecord::Migration.new.quote` + # returns incorrect value ('true'), which causes migrations to fail. + # quoted_value = connection.quote(value) processed = 0 |