summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorYorick Peterse <yorickpeterse@gmail.com>2016-01-06 15:30:02 +0100
committerYorick Peterse <yorickpeterse@gmail.com>2016-01-06 16:37:14 +0100
commit7549102bb727daecc51da84af39956b32fc41537 (patch)
tree598f69ee2b26b8411be7ca8d4563a916c92e5544 /lib
parent8b39b8cd54bb73b485ee6ea7fc5d3bbfbe07cd5d (diff)
downloadgitlab-ce-7549102bb727daecc51da84af39956b32fc41537.tar.gz
Store SQL/view timings in milliseconds
Transaction timings are also already stored in milliseconds, this keeps things consistent.
Diffstat (limited to 'lib')
-rw-r--r--lib/gitlab/metrics/subscribers/action_view.rb8
-rw-r--r--lib/gitlab/metrics/subscribers/active_record.rb6
2 files changed, 11 insertions, 3 deletions
diff --git a/lib/gitlab/metrics/subscribers/action_view.rb b/lib/gitlab/metrics/subscribers/action_view.rb
index 7c0105d543a..84d9e383625 100644
--- a/lib/gitlab/metrics/subscribers/action_view.rb
+++ b/lib/gitlab/metrics/subscribers/action_view.rb
@@ -19,7 +19,7 @@ module Gitlab
values = values_for(event)
tags = tags_for(event)
- current_transaction.increment(:view_duration, event.duration)
+ current_transaction.increment(:view_duration, duration(event))
current_transaction.add_metric(SERIES, values, tags)
end
@@ -28,7 +28,7 @@ module Gitlab
end
def values_for(event)
- { duration: event.duration }
+ { duration: duration(event) }
end
def tags_for(event)
@@ -48,6 +48,10 @@ module Gitlab
def current_transaction
Transaction.current
end
+
+ def duration(event)
+ event.duration * 1000.0
+ end
end
end
end
diff --git a/lib/gitlab/metrics/subscribers/active_record.rb b/lib/gitlab/metrics/subscribers/active_record.rb
index 8008b3bc895..6fa73e7a3be 100644
--- a/lib/gitlab/metrics/subscribers/active_record.rb
+++ b/lib/gitlab/metrics/subscribers/active_record.rb
@@ -8,7 +8,7 @@ module Gitlab
def sql(event)
return unless current_transaction
- current_transaction.increment(:sql_duration, event.duration)
+ current_transaction.increment(:sql_duration, duration(event))
end
private
@@ -16,6 +16,10 @@ module Gitlab
def current_transaction
Transaction.current
end
+
+ def duration(event)
+ event.duration * 1000.0
+ end
end
end
end