diff options
| author | Z.J. van de Weg <git@zjvandeweg.nl> | 2017-01-04 21:24:58 +0100 |
|---|---|---|
| committer | Z.J. van de Weg <git@zjvandeweg.nl> | 2017-01-05 19:59:10 +0100 |
| commit | 6ef6f9f205b8bed4ff0af4a353e7b04e0ff0b345 (patch) | |
| tree | d557c2da9f2afc17e3ecc96f6c7c5225e2623701 /lib | |
| parent | cd85baf5e363847ee1cca2e154e5fb47484e0fdf (diff) | |
| download | gitlab-ce-6ef6f9f205b8bed4ff0af4a353e7b04e0ff0b345.tar.gz | |
Do not check for valid url for .gitlab-ci.yml
Until this commit, GitLab would check if the URL in your .gitlab-ci.yml
would be valid and adressable. However, this approach is rather limited.
To begin, the URL couldn't be http://example:$PORT/my-project, as the
PORT value would be interpolated after checking if the URL was valid,
which its not. Also this gem will limit the amount of protocols allowed.
This commit doesn't check, at all, if the URL is valid. This is now the
responsablilty of the user. In my opion this is right, as the user
ultimately benefits from a correct URL, but also, its impossible to
cover all cases.
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/gitlab/ci/config/entry/environment.rb | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/gitlab/ci/config/entry/environment.rb b/lib/gitlab/ci/config/entry/environment.rb index b7b4b91eb51..f7c530c7d9f 100644 --- a/lib/gitlab/ci/config/entry/environment.rb +++ b/lib/gitlab/ci/config/entry/environment.rb @@ -33,7 +33,6 @@ module Gitlab validates :url, length: { maximum: 255 }, - addressable_url: true, allow_nil: true validates :action, |