diff options
| author | Toon Claes <toon@gitlab.com> | 2019-07-04 18:47:16 +0000 |
|---|---|---|
| committer | Mayra Cabrera <mcabrera@gitlab.com> | 2019-07-04 18:47:16 +0000 |
| commit | 37e4d6d991ac8e712ea99c621f98831955b6ebf5 (patch) | |
| tree | 75d76059e5df9d9b3c5622aa6dad0344dc9cc42f /lib | |
| parent | 507dfc66b480c0df097daefe86bf3a6bb3b2210f (diff) | |
| download | gitlab-ce-37e4d6d991ac8e712ea99c621f98831955b6ebf5.tar.gz | |
DRY up conditions for files require DB review
Stop using two separate lists for the conditions which files require a
database review.
Related discussion:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/30156#note_187732053
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/gitlab/danger/helper.rb | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/lib/gitlab/danger/helper.rb b/lib/gitlab/danger/helper.rb index 1ecf4a12db7..0fc145534bf 100644 --- a/lib/gitlab/danger/helper.rb +++ b/lib/gitlab/danger/helper.rb @@ -103,6 +103,11 @@ module Gitlab yarn\.lock )\z}x => :frontend, + %r{\A(ee/)?db/} => :database, + %r{\A(ee/)?lib/gitlab/(database|background_migration|sql|github_import)(/|\.rb)} => :database, + %r{\A(app/models/project_authorization|app/services/users/refresh_authorized_projects_service)(/|\.rb)} => :database, + %r{\Arubocop/cop/migration(/|\.rb)} => :database, + %r{\A(ee/)?app/(?!assets|views)[^/]+} => :backend, %r{\A(ee/)?(bin|config|danger|generator_templates|lib|rubocop|scripts)/} => :backend, %r{\A(ee/)?spec/features/} => :test, @@ -112,7 +117,6 @@ module Gitlab %r{\A(Dangerfile|Gemfile|Gemfile.lock|Procfile|Rakefile|\.gitlab-ci\.yml)\z} => :backend, %r{\A[A-Z_]+_VERSION\z} => :backend, - %r{\A(ee/)?db/} => :database, %r{\A(ee/)?qa/} => :qa, # Files that don't fit into any category are marked with :none |