summaryrefslogtreecommitdiff
path: root/qa/qa/page/group
diff options
context:
space:
mode:
authorMark Lapierre <mlapierre@gitlab.com>2018-09-28 14:36:49 -0400
committerMark Lapierre <mlapierre@gitlab.com>2018-09-28 14:36:49 -0400
commit8589fa871ee5dd94f821e1f5cbbcee269b46acf9 (patch)
tree4894dbebe97d3f6ffd41bc58fe49661bfd95772d /qa/qa/page/group
parent1ed5ab50c7931cee1283b21512784a487668a27f (diff)
downloadgitlab-ce-8589fa871ee5dd94f821e1f5cbbcee269b46acf9.tar.gz
Optimize groups filter
When searching for a group, submit a request that returns only the filtered list of groups. This makes the state of the page more reliable because it avoids having to wait for the list of groups to dynamically refresh.
Diffstat (limited to 'qa/qa/page/group')
-rw-r--r--qa/qa/page/group/show.rb8
1 files changed, 3 insertions, 5 deletions
diff --git a/qa/qa/page/group/show.rb b/qa/qa/page/group/show.rb
index 74d20df76ba..58a9e861971 100644
--- a/qa/qa/page/group/show.rb
+++ b/qa/qa/page/group/show.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
module QA
module Page
module Group
@@ -25,11 +27,7 @@ module QA
end
def has_subgroup?(name)
- filter_by_name(name)
-
- page.has_text?(/#{name}|No groups or projects matched your search/, wait: 60)
-
- page.has_text?(name, wait: 0)
+ has_filtered_group?(name)
end
def go_to_new_subgroup