Standardize usage of `click_` and `go_to` on GUI tests

This MR addresses the following issue:
https://gitlab.com/gitlab-org/gitlab-ce/issues/57043
Based on the following comment:
https://gitlab.com/gitlab-org/gitlab-ce/issues/57043#note_136663994

14 files changed, 26 insertions, 34 deletions

diff --git a/qa/qa/page/project/issue/index.rb b/qa/qa/page/project/issue/index.rb
index 1035bf74a43..e987d279e21 100644
--- a/qa/qa/page/project/issue/index.rb
+++ b/qa/qa/page/project/issue/index.rb
@@ -7,7 +7,7 @@ module QA
             element :issue_link, 'link_to issue.title' # rubocop:disable QA/ElementWithPattern
           end
 
-          def go_to_issue(title)
+          def click_issue_link(title)
             click_link(title)
           end
         end
diff --git a/qa/qa/page/project/milestone/new.rb b/qa/qa/page/project/milestone/new.rb
index 992ef89004b..0db8d2cf766 100644
--- a/qa/qa/page/project/milestone/new.rb
+++ b/qa/qa/page/project/milestone/new.rb
@@ -17,7 +17,7 @@ module QA
             fill_element :milestone_description, description
           end
 
-          def create_new_milestone
+          def click_milestone_create_button
             click_element :milestone_create_button
           end
         end
diff --git a/qa/qa/page/project/new.rb b/qa/qa/page/project/new.rb
index 552b2293115..f841afbbffd 100644
--- a/qa/qa/page/project/new.rb
+++ b/qa/qa/page/project/new.rb
@@ -35,7 +35,7 @@ module QA
           end
         end
 
-        def go_to_import_project
+        def click_import_project
           click_on 'Import project'
         end
 
@@ -51,7 +51,7 @@ module QA
           click_on 'Create project'
         end
 
-        def go_to_create_from_template
+        def click_create_from_template_tab
           click_element(:project_create_from_template_tab)
         end
 
@@ -59,7 +59,7 @@ module QA
           choose visibility
         end
 
-        def go_to_github_import
+        def click_github_link
           click_link 'GitHub'
         end
       end
diff --git a/qa/qa/page/project/operations/environments/index.rb b/qa/qa/page/project/operations/environments/index.rb
index 63965a57edd..610a34385b1 100644
--- a/qa/qa/page/project/operations/environments/index.rb
+++ b/qa/qa/page/project/operations/environments/index.rb
@@ -10,7 +10,7 @@ module QA
               element :environment_link
             end
 
-            def go_to_environment(environment_name)
+            def click_environment_link(environment_name)
               wait(reload: false) do
                 find(element_selector_css(:environment_link), text: environment_name).click
               end
diff --git a/qa/qa/page/project/pipeline/index.rb b/qa/qa/page/project/pipeline/index.rb
index 19d83ecc4f4..0373a12f597 100644
--- a/qa/qa/page/project/pipeline/index.rb
+++ b/qa/qa/page/project/pipeline/index.rb
@@ -5,7 +5,7 @@ module QA::Page
         element :pipeline_link, 'class="js-pipeline-url-link"' # rubocop:disable QA/ElementWithPattern
       end
 
-      def go_to_latest_pipeline
+      def click_on_latest_pipeline
         css = '.js-pipeline-url-link'
 
         link = wait(reload: false) do
diff --git a/qa/qa/page/project/pipeline/show.rb b/qa/qa/page/project/pipeline/show.rb
index 6f8a66bf527..9c0b55b1c4c 100644
--- a/qa/qa/page/project/pipeline/show.rb
+++ b/qa/qa/page/project/pipeline/show.rb
@@ -42,11 +42,11 @@ module QA::Page
         end
       end
 
-      def go_to_job(job_name)
+      def click_job(job_name)
         find_element(:job_link, text: job_name).click
       end
 
-      def go_to_first_job
+      def click_on_first_job
         css = '.js-pipeline-graph-job-link'
 
         wait(reload: false) do
diff --git a/qa/qa/page/project/settings/protected_branches.rb b/qa/qa/page/project/settings/protected_branches.rb
index 76591a4e3fe..399a49d2420 100644
--- a/qa/qa/page/project/settings/protected_branches.rb
+++ b/qa/qa/page/project/settings/protected_branches.rb
@@ -32,22 +32,22 @@ module QA
           end
 
           def allow_no_one_to_push
-            click_allow(:push, 'No one')
+            go_to_allow(:push, 'No one')
           end
 
           def allow_devs_and_maintainers_to_push
-            click_allow(:push, 'Developers + Maintainers')
+            go_to_allow(:push, 'Developers + Maintainers')
           end
 
           # @deprecated
           alias_method :allow_devs_and_masters_to_push, :allow_devs_and_maintainers_to_push
 
           def allow_no_one_to_merge
-            click_allow(:merge, 'No one')
+            go_to_allow(:merge, 'No one')
           end
 
           def allow_devs_and_maintainers_to_merge
-            click_allow(:merge, 'Developers + Maintainers')
+            go_to_allow(:merge, 'Developers + Maintainers')
           end
 
           # @deprecated
@@ -59,7 +59,7 @@ module QA
 
           private
 
-          def click_allow(action, text)
+          def go_to_allow(action, text)
             click_element :"allowed_to_#{action}_select"
 
             within_element(:"allowed_to_#{action}_dropdown") do
diff --git a/qa/qa/page/project/show.rb b/qa/qa/page/project/show.rb
index 9c21d9ddbfa..1a9a2fd413f 100644
--- a/qa/qa/page/project/show.rb
+++ b/qa/qa/page/project/show.rb
@@ -76,13 +76,13 @@ module QA
           click_on 'Fork'
         end
 
-        def go_to_file(filename)
+        def click_file(filename)
           within_element(:file_tree) do
             click_on filename
           end
         end
 
-        def go_to_commit(commit_msg)
+        def click_commit(commit_msg)
           within_element(:file_tree) do
             click_on commit_msg
           end
diff --git a/qa/qa/page/project/sub_menus/operations.rb b/qa/qa/page/project/sub_menus/operations.rb
index cf9fc453565..24a99a9464c 100644
--- a/qa/qa/page/project/sub_menus/operations.rb
+++ b/qa/qa/page/project/sub_menus/operations.rb
@@ -14,7 +14,7 @@ module QA
             end
           end
 
-          def click_operations_environments
+          def go_to_operations_environments
             hover_operations do
               within_submenu do
                 click_element(:operations_environments_link)
@@ -22,7 +22,7 @@ module QA
             end
           end
 
-          def click_operations_kubernetes
+          def go_to_operations_kubernetes
             hover_operations do
               within_submenu do
                 click_link('Kubernetes')
diff --git a/qa/qa/page/project/sub_menus/repository.rb b/qa/qa/page/project/sub_menus/repository.rb
index 29eaa9a74de..4cc73a6b25a 100644
--- a/qa/qa/page/project/sub_menus/repository.rb
+++ b/qa/qa/page/project/sub_menus/repository.rb
@@ -20,7 +20,7 @@ module QA
             end
           end
 
-          def click_repository_branches
+          def go_to_repository_branches
             hover_repository do
               within_submenu do
                 click_element(:branches_link)
diff --git a/qa/qa/page/project/sub_menus/settings.rb b/qa/qa/page/project/sub_menus/settings.rb
index 62c594c0210..22743ebd0a1 100644
--- a/qa/qa/page/project/sub_menus/settings.rb
+++ b/qa/qa/page/project/sub_menus/settings.rb
@@ -14,7 +14,7 @@ module QA
             end
           end
 
-          def click_ci_cd_settings
+          def go_to_ci_cd_settings
             hover_settings do
               within_submenu do
                 click_link('CI / CD')
@@ -22,7 +22,7 @@ module QA
             end
           end
 
-          def click_members_settings
+          def go_to_members_settings
             hover_settings do
               within_submenu do
                 click_element :link_members_settings
@@ -30,7 +30,7 @@ module QA
             end
           end
 
-          def click_repository_settings
+          def go_to_repository_settings
             hover_settings do
               within_submenu do
                 click_link('Repository')
@@ -38,7 +38,7 @@ module QA
             end
           end
 
-          def go_to_settings
+          def click_settings
             within_sidebar do
               click_on 'Settings'
             end
diff --git a/qa/qa/page/project/wiki/edit.rb b/qa/qa/page/project/wiki/edit.rb
index 8d0eafa1818..1ccd67349c3 100644
--- a/qa/qa/page/project/wiki/edit.rb
+++ b/qa/qa/page/project/wiki/edit.rb
@@ -9,15 +9,7 @@ module QA
             element :edit_page_link, 'Edit' # rubocop:disable QA/ElementWithPattern
           end
 
-          def go_to_new_page
-            click_on 'New page'
-          end
-
-          def got_to_view_history_page
-            click_on 'Page history'
-          end
-
-          def go_to_edit_page
+          def click_edit
             click_on 'Edit'
           end
         end
diff --git a/qa/qa/page/project/wiki/new.rb b/qa/qa/page/project/wiki/new.rb
index b90e03be36a..792eba4bab7 100644
--- a/qa/qa/page/project/wiki/new.rb
+++ b/qa/qa/page/project/wiki/new.rb
@@ -23,7 +23,7 @@ module QA
             element :svg_content
           end
 
-          def go_to_create_first_page
+          def click_create_your_first_page_button
             # The svg takes a fraction of a second to load after which the
             # "Create your first page" button shifts up a bit. This can cause
             # webdriver to miss the hit so we wait for the svg to load before
diff --git a/qa/qa/page/project/wiki/show.rb b/qa/qa/page/project/wiki/show.rb
index dffbc5d60a2..f79ad510084 100644
--- a/qa/qa/page/project/wiki/show.rb
+++ b/qa/qa/page/project/wiki/show.rb
@@ -11,7 +11,7 @@ module QA
             element :clone_repository_link, 'Clone repository' # rubocop:disable QA/ElementWithPattern
           end
 
-          def go_to_clone_repository
+          def click_clone_repository
             click_on 'Clone repository'
           end
         end