summaryrefslogtreecommitdiff
path: root/qa/qa/page
diff options
context:
space:
mode:
authorGrzegorz Bizon <grzesiek.bizon@gmail.com>2017-12-07 14:55:51 +0100
committerGrzegorz Bizon <grzesiek.bizon@gmail.com>2017-12-07 14:55:51 +0100
commitb80dc88441ff251096d23e596f8933cab072912f (patch)
treef1240415772171469c7446a712601f6dcfc44fe3 /qa/qa/page
parent86aa7ac13bc256b6e35d6e02773598ca01a552b9 (diff)
downloadgitlab-ce-b80dc88441ff251096d23e596f8933cab072912f.tar.gz
Decouple subject's address from page objects in QA
Diffstat (limited to 'qa/qa/page')
-rw-r--r--qa/qa/page/base.rb8
-rw-r--r--qa/qa/page/main/login.rb4
-rw-r--r--qa/qa/page/mattermost/login.rb4
3 files changed, 8 insertions, 8 deletions
diff --git a/qa/qa/page/base.rb b/qa/qa/page/base.rb
index 1d4a5c54969..4e1a55337c9 100644
--- a/qa/qa/page/base.rb
+++ b/qa/qa/page/base.rb
@@ -22,10 +22,6 @@ module QA
yield if block_given?
end
- def self.address
- raise NotImplementedError
- end
-
def scroll_to(selector, text: nil)
page.execute_script <<~JS
var elements = Array.from(document.querySelectorAll('#{selector}'));
@@ -40,6 +36,10 @@ module QA
page.within(selector) { yield } if block_given?
end
+
+ def self.path
+ raise NotImplementedError
+ end
end
end
end
diff --git a/qa/qa/page/main/login.rb b/qa/qa/page/main/login.rb
index 4c38f81bce7..f88325f408b 100644
--- a/qa/qa/page/main/login.rb
+++ b/qa/qa/page/main/login.rb
@@ -18,8 +18,8 @@ module QA
click_button 'Sign in'
end
- def self.address
- Runtime::Scenario.gitlab_address + '/users/sign_in'
+ def self.path
+ '/users/sign_in'
end
end
end
diff --git a/qa/qa/page/mattermost/login.rb b/qa/qa/page/mattermost/login.rb
index 9eb43fdc1b2..8ffd4fdad13 100644
--- a/qa/qa/page/mattermost/login.rb
+++ b/qa/qa/page/mattermost/login.rb
@@ -10,8 +10,8 @@ module QA
end
end
- def self.address
- Runtime::Scenario.gitlab_address + '/login'
+ def self.path
+ '/login'
end
end
end