Wait for Runner to register in QA and DRY page objects

1 files changed, 6 insertions, 2 deletions

diff --git a/qa/qa/service/runner.rb b/qa/qa/service/runner.rb
index a9906b8627a..2745bf00ded 100644
--- a/qa/qa/service/runner.rb
+++ b/qa/qa/service/runner.rb
@@ -6,11 +6,11 @@ module QA
       include Scenario::Actable
       include Service::Shellout
 
-      attr_writer :token, :address, :tags, :image, :name
+      attr_accessor :token, :address, :tags, :image, :name
 
       def initialize
         @image = 'gitlab/gitlab-runner:alpine'
-        @name = "gitlab-runner-qa-#{SecureRandom.hex(4)}"
+        @name = "qa-runner-#{SecureRandom.hex(4)}"
       end
 
       def pull
@@ -18,6 +18,10 @@ module QA
       end
 
       def register!
+        ##
+        # TODO, this assumes that `test` network exists, because we know that
+        # gitlab-qa environment orchestration tool creates it.
+        #
         shell <<~CMD.tr("\n", ' ')
           docker run -d --rm --entrypoint=/bin/sh
           --network test --name #{@name}